Re: [PATCH 1/3] staging: dgng: Fix Macros with complex values should be enclosed in parenthesis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 25, 2014 at 12:26:51AM +0900, Seunghun Lee wrote:
> This patch fixes a checkpatch errors
> "Macros with complex values should be enclosed in parenthesis"
> 
> Signed-off-by: Seunghun Lee <waydi1@xxxxxxxxx>
> ---
>  drivers/staging/dgnc/dgnc_driver.h |   40 ++++++++++++------------
>  drivers/staging/dgnc/digi.h        |   60 ++++++++++++++++++------------------
>  drivers/staging/dgnc/dpacompat.h   |   12 ++++----
>  3 files changed, 56 insertions(+), 56 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index fe5ea90..f7730a1 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -111,32 +111,32 @@
>  #endif
>  
>  #if defined TRC_TO_KMEM
> -#define PRINTF_TO_KMEM(args) dgnc_tracef args
> +#define PRINTF_TO_KMEM(args) do { dgnc_tracef args } while (0)

This is *so* nasty...  I suspect the only reason it works is because
TRC_TO_KMEM is never defined.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux