Re: [PATCH 1/1] staging: vme: removed useless breaks in vme_user.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/07/14 17:17, Tom Jorquera wrote:
vme_user.c contained unnecessary breaks after gotos, which increased
code size and caused code style warning. This is now fixed.

Signed-off-by: Tom Jorquera <tom.jorquera@xxxxxxxxx>

Acked-by: Martyn Welch <martyn.welch@xxxxxx>

---
  drivers/staging/vme/devices/vme_user.c | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
index 2d84972..920e50a 100644
--- a/drivers/staging/vme/devices/vme_user.c
+++ b/drivers/staging/vme/devices/vme_user.c
@@ -433,7 +433,6 @@ static loff_t vme_user_llseek(struct file *file, loff_t off, int whence)
  	default:
  		mutex_unlock(&image[minor].mutex);
  		return -EINVAL;
-		break;
  	}

  	if ((absolute < 0) || (absolute >= image_size)) {
@@ -511,7 +510,6 @@ static int vme_user_ioctl(struct inode *inode, struct file *file,
  			}

  			return retval;
-			break;

  		case VME_SET_MASTER:

@@ -552,7 +550,6 @@ static int vme_user_ioctl(struct inode *inode, struct file *file,
  			}

  			return retval;
-			break;

  		case VME_SET_SLAVE:

@@ -806,7 +803,6 @@ static int vme_user_probe(struct vme_dev *vdev)
  		default:
  			err = -EINVAL;
  			goto err_sysfs;
-			break;
  		}

  		num = (type[i] == SLAVE_MINOR) ? i - (MASTER_MAX + 1) : i;


--
Martyn Welch (Lead Software Engineer)  | Registered in England and Wales
GE Intelligent Platforms               | (3828642) at 100 Barbirolli Square
T +44(0)1327322748                     | Manchester, M2 3AB
E martyn.welch@xxxxxx                  | VAT:GB 927559189
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux