On Sat, Jul 19, 2014 at 12:59:22PM -0700, Joe Perches wrote:
> On Sat, 2014-07-19 at 21:34 +0200, Riccardo Lucchese wrote:
> > It is silly to go through an if statement to set a single boolean
> > value in function of a single boolean expression. In the function
> > lov_check_set, assign the return value directly.
> []
> > diff --git a/drivers/staging/lustre/lustre/lov/lov_request.c b/drivers/staging/lustre/lustre/lov/lov_request.c
> []
> > @@ -140,14 +140,13 @@ void lov_set_add_req(struct lov_request *req, struct lov_request_set *set)
> >
> > static int lov_check_set(struct lov_obd *lov, int idx)
> > {
> > - int rc = 0;
> > + int rc;
> > mutex_lock(&lov->lov_lock);
> >
> > - if (lov->lov_tgts[idx] == NULL ||
> > - lov->lov_tgts[idx]->ltd_active ||
> > - (lov->lov_tgts[idx]->ltd_exp != NULL &&
> > - class_exp2cliimp(lov->lov_tgts[idx]->ltd_exp)->imp_connect_tried))
> > - rc = 1;
> > + rc = lov->lov_tgts[idx] == NULL ||
> > + lov->lov_tgts[idx]->ltd_active ||
> > + (lov->lov_tgts[idx]->ltd_exp != NULL &&
> > + class_exp2cliimp(lov->lov_tgts[idx]->ltd_exp)->imp_connect_tried);
> >
> > mutex_unlock(&lov->lov_lock);
> > return rc;
>
> Maybe consider using a temporary for lov->lov_tgtx[idx] like:
[...]
Indeed, it is nicer this way.
Thanks,
Riccardo
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
