On Sat, Jul 19, 2014 at 10:26:53AM -0400, Benjamin Romer wrote: > This patch set moves several interfaces in the visorchipset module from procfs > to sysfs, and removes the remaining proc interfaces from the module. It includes > documentation for the new interfaces in Documentation/ABI, and some code cleanup > in the new sysfs handler functions. What happened to the idea of only creating the sysfs files _if_ it is needed? You are always creating these files, and then can return -ENODEV if the device really isn't there, that's not what you should do for a sysfs file. If the file is present, it should return data, not return an error. If the device isn't there, just don't create the file. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
