Re: [PATCH] staging: gdm72xx: conditionally compile debug code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-07-16 at 15:10 -0700, Greg KH wrote:
> On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote:
[]
> > Ok, I agree on the ifdef stuff. My question was regarding your
> > suggestion above to replace print_hex_debug() with dev_dbg()
> 
> You want the device name/id/label to show up as well, that is why you
> should use the dev_dbg() version, print_hex_dump() does not take a
> struct device *, so the user has no idea what device this data was
> coming from.

But Michalis could alway add something like:
	dev_hex_dump()
and
	dev_dbg_hex_dump()


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux