Re: [PATCH 01/15] staging: comedi: ni_daq_700: remove unnecessary enable and flush of ADC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 16, 2014 at 05:25:30PM +0000, Hartley Sweeten wrote:
> On Wednesday, July 16, 2014 4:35 AM, Ian Abbott wrote:
> > On 2014-07-15 01:20, H Hartley Sweeten wrote:
> >> The ADC conversions are enabled and the FIFO is flushed by daq700_ai_config()
> >> when the driver is initially attached. There is no reason to repeat the ADC
> >> enable and flush the FIFO before each sample read in the (*insn_read).
> >>
> >> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> >> Cc: Ian Abbott <abbotti@xxxxxxxxx>
> >> Cc: Greg Kroah-Hartman <gregk@xxxxxxxxxxxxxxxxxxx>
> >
> > I wouldn't be comfortable changing that - it looks important.  Could you 
> > run it past Fred Brooks?
> 
> Greg,
> 
> Please drop this series until I can get some feedback from Fred Brooks.

Now dropped, thanks.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux