Re: [PATCH 07/10] staging: unisys: fix chipsetready parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 15, 2014 at 01:30:47PM -0400, Benjamin Romer wrote:
> +	char msgtype[64];
> +	int msgparam;
> +
> +	if (sscanf(buf, "%64s %d", msgtype, &msgparam) == 2) {

The 64 in "%s64s" is off by one because of the NUL.

[ This is where I do my memory corruption preventing dance of success.
  I did that with my eyeballs, yo! *flex* *flex* ]

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux