On 07/15, Kevin Folz wrote: > Hello, > > > > I noticed you two have worked on the staging rtl8821ae driver. > > > > I wrote to the mailing list last month, but have yet to receive a > response. > > http://permalink.gmane.org/gmane.linux.kernel.wireless.general/125235 > > > > > I downloaded the latest linux kernel, 3.16.0rc2+, and created a patch > (attached) based on changes to rtl8192ee > > mac80211 had a change to regulatory defines, so I ported the changes to > your driver. > > > > rtl8821ae driver now successfully initializes on boot. > > > > I've never submitted to the Linux kernel before, I hope you can apply > this patch. > > > > Thanks, > Kevin Folz > Hello Kevin, first of all thanks for your submission and the changes that you have made. Now, since I'm not the right person to recieve such patches I'm going to use this opportunity and show you how you can do better. You can learn how to send patches by reading Documentation/SendPatches document. This is good place to start because it covers everything that is needed to make a successfull submission. In short you should send your patch inlined in the mail body to the mantainer of the staging subsystem and the 'driver devel' mailing list. Yes, you can include developer such as me that have contributed to the portion of kernel that you are working on however the important thing is to include the mantainers and the mailing list. This is because each patch before it is accepted is reviewed by multiple people and changed according to their comments. This is how the Linux kernel development is taking place. Before you send your patch make sure that your changes are compliant with the coding standard that the Linux kernel developers are following. You can learn it by reading Documentation/CodingStyle document and check for issues in your patches by using scripts/checkpatch.pl script. When your patch is good and contains no coding style issues you can use the scripts/get_mantainer.pl script to list the people and mailing lists that are interested in seeing changes to this code area. The last thing that you should do is to send it. When you work witch patches the easiest thing is to use git for it. Just read about the git send-email command. I know that it is a bit of reading however I assure you that the whole process despite of being precisely documented is not difficult at all. I suggest that you learn the process, send your patch again now in the proper manner and we will take it from there. Good Luck PS: I forward this message to the driver devel mailing list where the other people might help you too. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
