Re: [PATCH] staging: unisys: added virtpci info entry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 15, 2014 at 11:31:03AM -0400, Erik Arfvidson wrote:
> 
> On 07/15/2014 10:45 AM, Greg KH wrote:
> >[SNIP]
> >+#define MAX_BUF 16384
> >Lovely magic number, care to explain why this is this size?
> 
> Assuming we have the maximum possible configuration:
> 4 busses, 32 devices per bus, and we assume max of 80
> characters per linegives us 10,560 bytes which rounds
> up to 2^14.

Then _DOCUMENT IT_.

So in 5 years, when you look at the code again, you will remember this
is how you came up with that number.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux