On Sun, Jul 13, 2014 at 2:17 PM, Hartley Sweeten <HartleyS@xxxxxxxxxxxxxxxxxxx> wrote: > On Saturday, July 12, 2014 3:44 PM, Chase Southwood wrote: >> Use the addi_watchdog module to provide support for the watchdog >> subdevice. >> >> Also, rearrange the subdevice init blocks so that the order makes sense. >> Digital input/output subdevices and subdevices for DI/DO interrupt >> support, followed by timer/counter/watchdog subdevices is the new order. >> >> Signed-off-by: Chase Southwood <chase.southwood@xxxxxxxxx> >> Cc: Ian Abbott <abbotti@xxxxxxxxx> >> Cc: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> >> --- >> drivers/staging/comedi/drivers/addi_apci_1564.c | 34 +++++++++++++++---------- >> 1 file changed, 20 insertions(+), 14 deletions(-) > > Chase, > > You should also add the dependency for the addi watchdog module > to the Kconfig. > Hello, Hartley! The select statement for COMEDI_ADDI_WATCHDOG was added to Kconfig for the addi_apci_1564 driver in commit 8851362: From: Arnd Bergmann <arnd@xxxxxxxx> Date: Tue, 3 Jun 2014 12:29:29 +0200 Subject: [PATCH] staging: comedi: addi_apci_1564: add addi_watchdog dependency Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Cc: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> Acked-by: Ian Abbott <abbotti@xxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> This is because the driver has already been using addi_watchdog_reset() and I had forgotten to add the select to the Kconfig when I added that function call, so Arnd added it when a randconfig build error turned up later. Sorry for the confusion. Thanks, Chase > Regards, > Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
