2014-07-08 16:08 GMT+02:00 Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>: > Use signed type to check correctly for negative error code. The issue > was reported with static analyser: > > [linux-3.13/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c:270]: > (style) A pointer can not be negative so it is either pointless or an > error to check if it is. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=69071 > Reported-by: David Binderman <dcb314@xxxxxxxxxxx> > Signed-off-by: Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx> Hmm, while it is true that get_ipipe_mode returns an int, but the consequent call to regw_ip takes an u32 as its second argument. Did it cause a build warning for you? (Can't really check since I don't have ARM cross compilers close-by) If not, then: Reviewed-by: Levente Kurusa <lkurusa@xxxxxxxxxx> Thanks, Levente Kurusa _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
