On Tue, Jun 24, 2014 at 10:52:41PM -0400, James A Shackleford wrote:
> Signed-off-by: James A Shackleford <shack@xxxxxxxxx>
> ---
> drivers/staging/rtl8712/osdep_service.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h
> index 77b1443..3dfc473 100644
> --- a/drivers/staging/rtl8712/osdep_service.h
> +++ b/drivers/staging/rtl8712/osdep_service.h
> @@ -95,11 +95,6 @@ static inline void _set_workitem(_workitem *pwork)
> #define BIT(x) (1 << (x))
> #endif
>
> -/*
> -For the following list_xxx operations,
> -caller must guarantee the atomic context.
> -Otherwise, there will be racing condition.
> -*/
> static inline u32 _down_sema(struct semaphore *sema)
> {
> if (down_interruptible(sema))
This function sucks obviously just like the wrappers you deleted earlier.
Only one of the callers checks the return value.
TODO-list: 2014-07-08: rtl8712: delete _down_sema().
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
