Re: [PATCH 2/4] Staging: rts5208: Use standard print_hex_dump_debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2014-07-06 at 18:32 +0200, Fabio Falzoi wrote:
> Have I to fix just the commit message or is this behaviour not suitable?
> In the latter case, could you please suggest a way to fix this?

Hi Fabio.

I think it's not appropriate.
I'd've changed it to something like:

#if DEBUG
#define rtsx_hex_dump(buf, len)						\
	print_hex_dump_bytes(KBUILD_MODNAME ": ", DUMP_PREFIX_NONE,	\
			     buf, len)
#else
#define rtsx_hex_dump(buf, len)
	do {;} while (0)
#endif


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux