On Fri, 4 Jul 2014 22:59:41 +0200 Julian Andres Klode <jak@xxxxxxxxxxxxx> wrote: > On Fri, Jul 04, 2014 at 09:57:50PM +0200, Pawel Lebioda wrote: > > Hi, > > > > This patch fixes the following warning reported by checkpatch.pl: > > > > WARNING: else is not generally useful after a break or return > > #235: FILE: drivers/staging/nvec/nvec.c:235: > > > > Regards > > Pawel Lebioda > > > > Signed-off-by: Pawel Lebioda <pawel.lebioda89@xxxxxxxxx> > > drivers/staging/nvec/nvec.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Hi Pawel, > > Please format your patches correctly. There should be no > "Hi", no "Regards", etc. After the signed off should be a > dashed line. > > Use git format-patch to format patches and you can send > them using git-send-email. yes, this way you reduce some apply-burdon from Greg. Ideally, you would combine all patches (one patch per checkpatch warning) in a common thread like this: git-format-patch --cover-letter --thread -s <first commit of your patches> This way you could add some comments (if any) to the cover letter and just keep the plain checkpatch message in the other patches. This has also the advantage that the maintainers only have to ack the "cover letter". Marc -- Marc Dietrich <marvin24@xxxxxx> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
