On Fri, Jul 04, 2014 at 05:00:36PM +0530, Sachin Kamat wrote: > On Fri, Jul 4, 2014 at 4:22 PM, Russell King - ARM Linux > <linux@xxxxxxxxxxxxxxxx> wrote: > > On Fri, Jul 04, 2014 at 04:17:35PM +0530, Sachin Kamat wrote: > >> Hi Russell > >> > >> > +int component_master_add_with_match(struct device *dev, > >> > + const struct component_master_ops *ops, > >> > + struct component_match *match) > >> > { > >> > struct master *master; > >> > int ret; > >> > > >> > + if (ops->add_components && match) > >> > + return -EINVAL; > >> > + > >> > + /* Reallocate the match array for its true size */ > >> > + match = component_match_realloc(dev, match, match->num); > >> > >> ^^^^^^^^^^^^^ > >> This gives a NULL pointer dereference error when match is NULL (as passed > >> by component_master_add() below). Observed this while testing linux-next > >> kernel (next-20140704) on Exynos based board with DRM enabled. > > > > Thanks for your report. Please verify that the patch below resolves it > > for you. Thanks. > > Yes, the below patch fixes the crash. Thanks for the fix. Thanks. I'll add a tested-by and reported-by for your address when committing this patch. Let me know if you want something different. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel