Re: [PATCH RFC v2 3/8] component: add support for component match array

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 26, 2014 at 03:46:01PM +0100, Russell King - ARM Linux wrote:
> On Thu, Jun 26, 2014 at 02:34:17PM +0200, Philipp Zabel wrote:
> > Hi Russell,
> > 
> > On Tue, Jun 24, 2014 at 9:29 PM, Russell King
> > <rmk+kernel@xxxxxxxxxxxxxxxx> wrote:
> > [...]
> > > +/*
> > > + * Add a component to be matched.
> > > + *
> > > + * The match array is first created or extended if necessary.
> > > + */
> > > +void component_match_add(struct device *dev, struct component_match **matchptr,
> > > +       int (*compare)(struct device *, void *), void *compare_data)
> > > +{
> > > +       struct component_match *match = *matchptr;
> > > +
> > > +       if (IS_ERR(match))
> > > +               return;
> > > +
> > > +       if (!match || match->num == match->alloc) {
> > > +               size_t new_size = match ? match->alloc + 16 : 15;
> > > +
> > > +               match = component_match_realloc(dev, match, new_size);
> > > +
> > > +               *matchptr = match;
> > > +
> > > +               if (IS_ERR(match))
> > > +                       return;
> > > +       }
> > > +
> > > +       match->compare[match->num].fn = compare;
> > > +       match->compare[match->num].data = compare_data;
> > > +       match->num++;
> > > +}
> > 
> > component_match_add should be exported.
> 
> Fixed, thanks.

As there's no further comments, and Inki Dae has not responded, I'm
going to send these out without the RFC tag in the hope that people
will provide acks.  This allows us to move forward with this despite
the Exynos DRM blockage.

The ultimate plan is for patches 1 to 3 inclusive to be merged into
Greg's driver tree, 1 to 3 and 5 into Greg's staging tree, and 1 to
3 and 4 for David Airlie's DRM tree - patches 1 to 3 are needed for
both patches 4 and 5.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux