Re: [PATCH] staging: rtl8188eu: re-use mac_pton() and hex2bin() helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 27, 2014 at 04:53:32PM +0300, Andy Shevchenko wrote:
> The helper mac_pton() validates and converts MAC address from string format to
> a number. Originally code uses simple code to do that. With mac_pton() the
> driver now validates input as well.
> 
> MEanwhile hex2bin() converts hexdecimal strings to its binary representation.
> As the other helper it validates the input.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

You are doing a lot of different things all at once here in this patch.
Please break it up into doing "one thing per patch" series and resubmit.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux