Re: [jes:rtl8723au-devel 206/499] WARNING: __func__ should be used instead of gcc specific __FUNCTION__

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fengguang Wu <fengguang.wu@xxxxxxxxx> writes:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git rtl8723au-devel
> head:   07068767ab5cc9eb549dc85cb858e00c384ade4c
> commit: 068bf12cd5cc11f85a5b4d5423e629b640e12df7 [206/499] staging: rtl8723au: hal/usb_ops_linux.c: Various cleanups
>
> scripts/checkpatch.pl 0001-staging-rtl8723au-hal-usb_ops_linux.c-Various-cleanu.patch
> # many are suggestions rather than must-fix
>
> WARNING: quoted string split across lines
> #27: drivers/staging/rtl8723au/hal/usb_ops_linux.c:41:
> +			 ("usbctrl_vendorreq:(padapter->bSurpriseRemoved||"
> +			  "adapter->pwrctrlpriv.pnp_bstop_trx)!!!\n"));
>
> WARNING: __func__ should be used instead of gcc specific __FUNCTION__
> #35: drivers/staging/rtl8723au/hal/usb_ops_linux.c:48:
> +			  __FUNCTION__);
>
> WARNING: Missing a blank line after declarations
> #57: drivers/staging/rtl8723au/hal/usb_ops_linux.c:100:
> +					struct hal_data_8723a *pHalData;
> +					pHalData = GET_HAL_DATA(padapter);

Hi Fengguang,

Thanks for the report, I fixed the above. The rest of the reports here
seem to have been fixed already through other patches.

Cheers,
Jes
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux