[PATCH 05/15] Staging: bcm: led_control.c: Replaced member accessing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch replaces member accessing with a variable in
BcmGetGPIOPinInfo().

Signed-off-by: Matthias Beyer <mail@xxxxxxxxxxxxxxxx>
---
 drivers/staging/bcm/led_control.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c
index f528a45..085493a 100644
--- a/drivers/staging/bcm/led_control.c
+++ b/drivers/staging/bcm/led_control.c
@@ -626,33 +626,31 @@ static INT BcmGetGPIOPinInfo(struct bcm_mini_adapter *Adapter,
 			     enum bcm_led_events currdriverstate)
 {
 	UINT uiIndex = 0;
+	struct bcm_led_state_info *led_state_info;
 
 	*GPIO_num_tx = DISABLE_GPIO_NUM;
 	*GPIO_num_rx = DISABLE_GPIO_NUM;
 
 	for (uiIndex = 0; uiIndex < NUM_OF_LEDS; uiIndex++) {
+		led_state_info = &Adapter->LEDInfo.LEDState[uiIndex];
 
 		if (((currdriverstate == NORMAL_OPERATION) ||
 			(currdriverstate == IDLEMODE_EXIT) ||
 			(currdriverstate == FW_DOWNLOAD)) &&
-		    (Adapter->LEDInfo.LEDState[uiIndex].LED_Blink_State &
-					currdriverstate)) {
-			if (Adapter->LEDInfo.LEDState[uiIndex].GPIO_Num
-					!= DISABLE_GPIO_NUM) {
+		    (led_state_info->LED_Blink_State & currdriverstate)) {
+			if (led_state_info->GPIO_Num != DISABLE_GPIO_NUM) {
 				if (*GPIO_num_tx == DISABLE_GPIO_NUM) {
-					*GPIO_num_tx = Adapter->LEDInfo.LEDState[uiIndex].GPIO_Num;
+					*GPIO_num_tx = led_state_info->GPIO_Num;
 					*uiLedTxIndex = uiIndex;
 				} else {
-					*GPIO_num_rx = Adapter->LEDInfo.LEDState[uiIndex].GPIO_Num;
+					*GPIO_num_rx = led_state_info->GPIO_Num;
 					*uiLedRxIndex = uiIndex;
 				}
 			}
 		} else {
-			if ((Adapter->LEDInfo.LEDState[uiIndex].LED_On_State &
-						currdriverstate) &&
-			    (Adapter->LEDInfo.LEDState[uiIndex].GPIO_Num !=
-			     DISABLE_GPIO_NUM)) {
-				*GPIO_num_tx = Adapter->LEDInfo.LEDState[uiIndex].GPIO_Num;
+			if ((led_state_info->LED_On_State & currdriverstate) &&
+			    (led_state_info->GPIO_Num != DISABLE_GPIO_NUM)) {
+				*GPIO_num_tx = led_state_info->GPIO_Num;
 				*uiLedTxIndex = uiIndex;
 			}
 		}
-- 
2.0.0

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux