Thanks for the feedback I will resend the patch fixed. Otherwise please use Larry's idea. Cheers Nick On Fri, Jun 20, 2014 at 4:08 PM, Joe Perches <joe@xxxxxxxxxxx> wrote: > On Fri, 2014-06-20 at 22:59 +0300, Dan Carpenter wrote: >> On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote: >> > Rewrites the wireless check for legacy checking in function >> > halbtc_legacy to check for both Mode A and B. >> >> You're just guessing that A and B were intended but it could have been >> something B and G... >> >> Don't do this. Just leave the static checker warning there so someone >> can fix it properly instead of introducing a second new bug and hiding >> the warning so it's impossible to find. >> > > It's most likely G anyway: > > drivers/staging/rtl8192ee/btcoexist/halbtcoutsrc.c: if ((mac->mode == WIRELESS_MODE_B) || (mac->mode == WIRELESS_MODE_G)) > drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c: if ((mac->mode == WIRELESS_MODE_B) || (mac->mode == WIRELESS_MODE_B)) > > Larry probably has a better idea. > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
