The National Instruments MIO drivers, ni_pcimio, ni_mio_cs, and ni_atmio, all include the ni_mio_common.c source file to provide the common functionality for the drivers. Including source files is a bit ugly. Remove some cruft from the NI drivers in preparation of converting ni_mio_common to a kernel module. H Hartley Sweeten (16): staging: comedi: ni_pcimio: remove forward declarations staging: comedi: ni_mio_common.c: remove interrupt_pin() macros staging: comedi: ni_mio_common drivers: remove NI_E_IRQ_FLAGS defines staging: comedi: ni_mio_common.c: remove IRQ_POLARITY defines staging: comedi: ni_atmio: remove '= 0' boardinfo data staging: comedi: ni_atmio: remove NI_SIZE define staging: comedi: ni_mio_cs: remove NI_SIZE define staging: comedi: ni_atmio: tidy up the boardinfo staging: comedi: ni_stc.h: the boardinfo 'name' should be first staging: comedi: ni_pcimio: remove DRV_NAME define staging: comedi: ni_atmio: remove ATMIO and PCIMIO defines staging: comedi: ni_mio_cs: remove ATMIO and PCIMIO defines staging: comedi: ni_pcimio: remove ATMIO and PCIMIO defines staging: comedi: mite.h: remove mite_irq() staging: comedi: mite.h: remove mite_device() staging: comedi: mite: cleanup mite_unsetup() drivers/staging/comedi/drivers/mite.c | 18 +- drivers/staging/comedi/drivers/mite.h | 17 +- drivers/staging/comedi/drivers/ni_65xx.c | 10 +- drivers/staging/comedi/drivers/ni_660x.c | 11 +- drivers/staging/comedi/drivers/ni_670x.c | 6 +- drivers/staging/comedi/drivers/ni_atmio.c | 298 +++++++++++-------------- drivers/staging/comedi/drivers/ni_labpc_pci.c | 8 +- drivers/staging/comedi/drivers/ni_mio_common.c | 9 +- drivers/staging/comedi/drivers/ni_mio_cs.c | 23 +- drivers/staging/comedi/drivers/ni_pcidio.c | 7 +- drivers/staging/comedi/drivers/ni_pcimio.c | 155 ++++++------- drivers/staging/comedi/drivers/ni_stc.h | 2 +- 12 files changed, 234 insertions(+), 330 deletions(-) -- 1.9.3 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel