On 2014-06-19 18:20, H Hartley Sweeten wrote:
The kbuild test robot pointed out some build errors on ARCH=ia64 of this type: drivers/staging/comedi/drivers/ni_pcimio.c:1105:42: error: macro "writew" passed 3 arguments, but takes just 2 It appears the read[lwb]/write[lwb] callabacks in struct ni_private are getting treated as macros if the architecture has these symbols defined as macros. For some resone these errors don't appear on ARCH=x86.
Because they're not defined as macros for x86.
Regardless, this series removes all the i/o callbacks from struct ni_private. The driver specific i/o handling is now handled in ni_mio_common.c based on if the driver has allocated the 'mite' device. If so the board uses memory mpped i/o (read[lwb]/write[lwb]), otherwise the board uses port mapped i/o (in[lwb]/out[lwb]). H Hartley Sweeten (6): staging: comedi: ni_stc.h: add a 'is_m_series' flag to private data staging: comedi: ni_stc.h: cleanup ni_e_series_enable_second_irq() staging: comedi: ni_mio_common.c: wrap the stc_read/write operations staging: comedi: ni_mio_common.c: wrap the read/write operations staging: comedi: ni_stc.h: remove read/write callbacks from ni_private staging: comedi: ni_stc.h: remove stc read/write callbacks from ni_private drivers/staging/comedi/drivers/ni_atmio.c | 85 +- drivers/staging/comedi/drivers/ni_mio_common.c | 1559 ++++++++++++++---------- drivers/staging/comedi/drivers/ni_mio_cs.c | 83 -- drivers/staging/comedi/drivers/ni_pcimio.c | 397 +----- drivers/staging/comedi/drivers/ni_stc.h | 14 +- 5 files changed, 960 insertions(+), 1178 deletions(-)
Too late now, but: Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
