On Fri, Jun 20, 2014 at 12:46:33PM +0200, Rickard Strandqvist wrote: > Hi > > It's a bit confusing with this, I have received a lot of complaints > that I have not had a cover letter. > When should I include it? In an obvious patching. But where there's a > need to explain anything further should have a cover letter. Cover letters are for if you have a series of patches and they follow a theme. "Add support for XXX feature in a series of 8 patches". "What is in my pull request for the new kernel." It's just a shorter summary. This is just one patch not a series. I have never sent a cover letter in my life. I don't know who is complaining to you... In this case the changelog would have been better and more complete if all the cover letter information were in the permanent commit log. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel