On Thu, Jun 19, 2014 at 01:11:40PM -0700, josh@xxxxxxxxxxxxxxxx wrote: > On Thu, Jun 19, 2014 at 09:20:15PM +0200, Johannes Stadlinger wrote: > > This patch inserts a blank line after a declaration to avoid checkpatch > > warning. > > > > Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@xxxxxx> > > Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email> > > CC: linux-kernel@xxxxxxxxxxxx > > CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > CC: Josh Triplett <josh@xxxxxxxxxxxxxxxx> > > CC: Himangi Saraogi <himangi774@xxxxxxxxx> > > CC: Vitaly Osipov <vitaly.osipov@xxxxxxxxx> > > CC: devel@xxxxxxxxxxxxxxxxxxxx > > CC: linux-kernel@xxxxxxxxxxxxxxx > > This is one case where I think checkpatch is just wrong; this doesn't > make the code any more (or less) readable. > > Meh-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx> We've asked about making checkpatch ignore small blocks but apparently that is a hard thing. It's less work to apply these than to argue about them and adding a space doesn't hurt so meh is correct. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
