Hey guys, Sorry about no reply, my power supply died last night, have to get a new one. I will be RMAing the old old in order to get a packup in case this PSU dies. Cheers Nick On Thu, Jun 19, 2014 at 1:29 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Wed, Jun 18, 2014 at 10:24:41PM -0400, Nicholas Krause wrote: >> Checks if dev_skb_alloc returns Null in function, fw_download_code. >> If the return value of dev_skb_alloc is NULL return false and exit >> this function. >> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx> >> --- >> drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c >> index 1a95d1f..38ae236 100644 >> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c >> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c >> @@ -62,6 +62,8 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, >> >> skb = dev_alloc_skb(frag_length + 4); >> memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev)); >> + if (!skb) >> + return !rt_status; > > What's this !rt_status? Just return false. > > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel