On Tue, Jun 17, 2014 at 12:14:18AM +0200, Rickard Strandqvist wrote: > 2014-06-16 21:09 GMT+02:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>: > > On Mon, Jun 16, 2014 at 10:01:14PM +0300, Dan Carpenter wrote: > >> > >> No one calls U14DriverName() so just delete this function. > > > > Oh. This is a userspace library or something? I'm not sure what to do. > > > > How did you compile test this? Does your platform even provide > > strlcpy()? > > > > Anyway, don't delete it like I said, but I still don't think your patch > > helps here. > > > > regards, > > dan carpenter > > > > Hi > > I saw that these functions are not used, had planned type it in the > cover letter to :-( > > Thought of userspec, but then it should definitely ensure the NULL char? The strings are always 4 characters long. If the user start passing 3 character buffers then it will *never* work. That means the bug will be caught on the first run in testing. I don't worry about those kinds of bugs very much. It's only a concern if it works 99 times and fails 1 time. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
