On Fri, Jun 13, 2014 at 08:31:40PM -0700, Joe Perches wrote: > On Fri, 2014-06-13 at 22:48 -0400, Jeff Oczek wrote: > > - s32(*fread) (void *, size_t, size_t, void *); > > - s32(*fseek) (void *, long, int); > > - s32(*ftell) (void *); > > - s32(*fclose) (void *); > > - void *(*fopen) (const char *, const char *); > > + s32 (*fread)(void *, size_t, size_t, void *); > > + s32 (*fseek)(void *, long, int); > > + s32 (*ftell)(void *); > > + s32 (*fclose)(void *); > > + void *(*fopen)(const char *, const char *); > > Better would be to describe the arguments with > variable names and align all the return values > > void *(*fopen > > s32 (*fread)(void *arg1, size_t val1, size_t val2, void *ptr1); > s32 (*fseek)(void *ptr1, long arg2, int arg3); > s32 (*ftell)(void * ptr); > s32 (*fclose)(void *ptr); > void *(*fopen)(const char *ptr1, const char *ptr2); > > where arg, val, ptr are actually useful descriptors > Thanks Joe. I was just trying to stay in the scope of making a really trivial coding style change for the sake of following the submission process for the first time. But I'll resend based on your suggestion. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
