On Thu, 2014-06-12 at 13:35 -0700, Greg Kroah-Hartman wrote: > On Thu, Jun 12, 2014 at 01:25:34PM -0700, Davidlohr Bueso wrote: > > On Thu, 2014-06-12 at 23:40 +0400, Wahib Faizi wrote: > > > Fix coding style issues detected by checkpatch.pl in usbip_host_driver.c. > > > > Sorry but unless bundled with something more meaningful, I really don't > > see the value in these changes. I certainly don't want to discourage > > folks or anything, but just testing other patches is a lot more helpful > > than this. > > When the staging code is still needing basic fixes like this, it is > "meaningful" to do patches that clean up stuff like this. That's what > the staging tree is for. Sure, but "making checkpatch happy just to make checkpatch happy" isn't a good justification, even for staging. Patch 1 does have value in that it helps avoid silly bugs, but take patch 2/2, we end-up saving just a few spaces... Anyways, just my 2 cents. Thanks, Davidlohr _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
