On Thu, Jun 12, 2014 at 10:33:09AM -0400, nick wrote: > Here is the fixed patch. Having issues with using Thunderbird > so just used Evolution for now. > Nick Please read the first paragraph of: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt It's not clear from reading this email why 0 is incorrect and 3<<16 is correct. Explain in the changelog. What are the user visible effects of this bug etc. The patch must have a signed-off-by line. Here is what typical patch emails should look like: https://lkml.org/lkml/2014/6/12/377 https://lkml.org/lkml/2014/6/12/369 https://lkml.org/lkml/2014/6/12/299 The subject should be: [PATCH] vme: ca91cx42: Bad if test something something Make sure it apply with `git am` and review the log. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel