On Thu, Jun 12, 2014 at 03:44:34AM +0000, Nick Krause wrote:
> Hey Fellow Developers,
> This is my first patch so if there are any errors please reply as i will
> fix them. Below is the patch.
> -- drivers/vme/bridges/vme_ca91cx42.h.orig 2014-06-11 22:50:29.339671939 -0400
> +++ drivers/vme/bridges/vme_ca91cx42.h 2014-06-11 23:15:36.027685173 -0400
> @@ -526,7 +526,7 @@ static const int CA91CX42_LINT_LM[] = {
> #define CA91CX42_VSI_CTL_SUPER_SUPR (1<<21)
>
> #define CA91CX42_VSI_CTL_VAS_M (7<<16)
> -#define CA91CX42_VSI_CTL_VAS_A16 0
> +#define CA91CX42_VSI_CTL_VAS_A16 (3<<16)
> #define CA91CX42_VSI_CTL_VAS_A24 (1<<16)
> #define CA91CX42_VSI_CTL_VAS_A32 (1<<17)
> #define CA91CX42_VSI_CTL_VAS_USER1 (3<<17)
> @@ -549,7 +549,7 @@ static const int CA91CX42_LINT_LM[] = {
> #define CA91CX42_LM_CTL_SUPR (1<<21)
> #define CA91CX42_LM_CTL_NPRIV (1<<20)
> #define CA91CX42_LM_CTL_AS_M (5<<16)
> -#define CA91CX42_LM_CTL_AS_A16 0
> +#define CA91CX42_LM_CTL_AS_A16 (3<<16)
> #define CA91CX42_LM_CTL_AS_A24 (1<<16)
> #define CA91CX42_LM_CTL_AS_A32 (1<<17)
> Signed-off-by: Nicholas Krause <nickkrause@xxxxxxxxxxxx>
Always run your patch through scripts/checkpatch.pl first to catch the
issues that are 'obvious'.
After that, the signed-off-by: needs to be up in the changelog area,
there needs to be a changelog explaining why this patch is needed, and
the tabs need to be put back in the patch (your email client ate them.)
Can you try again?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
