Hi
True!
Sorry :-(
But then one would either operate strcpy outright.
Or use strlcpy then the code would be:
/* strlcpy() handles not include \0 */
len = strlcpy(busid, buf + 4, BUSID_SIZE);
/* busid needs to include \0 termination */
if (!(len < BUSID_SIZE))
return -EINVAL;
Or should we just let it be, perhaps?
Kind regards
Rickard Strandqvist
2014-06-10 8:57 GMT+02:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
> On Wed, Jun 04, 2014 at 11:39:49PM +0200, Rickard Strandqvist wrote:
>> Added a guaranteed null-terminate after call to strncpy.
>>
>> This was partly found using a static code analysis program called cppcheck.
>>
>
> We already knew that the string was NUL terminated because we checked
> strnlen() on the lines before.
>
> regards,
> dan carpenter
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
