From: Ken Helias <kenhelias@xxxxxxxxxxx> Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias <kenhelias@xxxxxxxxxxx> Cc: devel@xxxxxxxxxxxxxxxxxxxx --- drivers/staging/tidspbridge/rmgr/rmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/tidspbridge/rmgr/rmm.c b/drivers/staging/tidspbridge/rmgr/rmm.c index 52187bd..7e1ba84 100644 --- a/drivers/staging/tidspbridge/rmgr/rmm.c +++ b/drivers/staging/tidspbridge/rmgr/rmm.c @@ -139,7 +139,7 @@ int rmm_alloc(struct rmm_target_obj *target, u32 segid, u32 size, &target->ovly_list); else /* Put new section just before sect */ - list_add_tail(&new_sect->list_elem, + list_add_before(&new_sect->list_elem, §->list_elem); } } -- 2.0.0 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel