Hi Vitaly, Thank you for the patch. On Thursday 05 June 2014 17:07:48 Vitaly Osipov wrote: > It makes more sense to return PTR_ERR(iss->iss_ctrlclk) here. The > current code looks like an oversight in pasting the block just above > this one. > > Signed-off-by: Vitaly Osipov <vitaly.osipov@xxxxxxxxx> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> and applied to my tree. > --- > drivers/staging/media/omap4iss/iss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/omap4iss/iss.c > b/drivers/staging/media/omap4iss/iss.c index 2e422dd..4a9e444 100644 > --- a/drivers/staging/media/omap4iss/iss.c > +++ b/drivers/staging/media/omap4iss/iss.c > @@ -1029,7 +1029,7 @@ static int iss_get_clocks(struct iss_device *iss) > if (IS_ERR(iss->iss_ctrlclk)) { > dev_err(iss->dev, "Unable to get iss_ctrlclk clock info\n"); > iss_put_clocks(iss); > - return PTR_ERR(iss->iss_fck); > + return PTR_ERR(iss->iss_ctrlclk); > } > > return 0; -- Regards, Laurent Pinchart _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel