Hi Okay, this code has been changed in linux-next, before the allocation before the switch statement. Yes, I repeat it to myself.. I'll check everything against linux-next in the future! Best regards Rickard Strandqvist 2014-06-02 10:41 GMT+02:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>: > On Sun, Jun 01, 2014 at 01:30:43PM +0200, Rickard Strandqvist wrote: >> There is a risk for memory leak in when something unexpected happens >> and the function returns. >> >> This was largely found by using a static code analysis program called cppcheck. >> >> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> >> --- >> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c >> index 23d539d..27e0243 100644 >> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c >> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c >> @@ -1822,6 +1822,7 @@ static int r871x_wx_set_enc_ext(struct net_device *dev, >> alg_name = "CCMP"; >> break; >> default: >> + kfree(param); > > Wat? Param isn't even allocated at this point. It gets allocated a > couple lines later. > > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
