On 02/06/14 18:05, Federico Di Pierro wrote:
Hi! This is my latest task of the eudyptula challenge. Just a very small patch! It fixes 3 little coding style problems. I'm using linux-next.
Fair enough, but you need to spend a little time working on the 'how' of your patch submission. See Documentation/SubmittingPatches and repost the patch according to those guidelines. Also at a quick glance, unless I am very bored I'm unlikely to take such a minor white space and bracket adjustment patch. If it were part of a bigger series doing something more interesting I'd be more interested. If you want to approach this driver, then feel free but there are many more major issues within it to be looked at such as ABI compliance. See Documentation/ABI/testing/sysfs-bus-iio and friends and compare the driver with them. Off the top of my head I can't remember how bad this driver is but I doubt everything is well documented. Don't feel disheartened, as I would be happy to see more substantial cleanup patches from you as part of the challenge or otherwise. Good luck, Jonathan _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
