On Thu, May 29, 2014 at 10:27 PM, Magnus Damm <magnus.damm@xxxxxxxxx> wrote: > Hi Dan, > > On Thu, May 29, 2014 at 10:20 PM, Dan Carpenter > <dan.carpenter@xxxxxxxxxx> wrote: >> On Thu, May 29, 2014 at 10:17:32PM +0900, Magnus Damm wrote: >>> --- /dev/null >>> +++ work/drivers/staging/board/Kconfig 2014-05-29 21:40:41.000000000 +0900 >>> @@ -0,0 +1,7 @@ >>> +config STAGING_BOARD >>> + boolean "Staging Board Support" >>> + help >>> + Select to enable per-board staging support code. >>> + >>> + If in doubt, say N here. >>> + >> >> Actually, you're probably going to need to add a bunch of dependencies >> here or it will break "make randconfig" right away. Sorry that I forgot >> about this in the first review. > > Good point, thanks for checking. I will have a look at this and add > dependencies to make sure it builds on a wide range of platforms. To begin with, this hunk fixes the i386_defconfig + staging board build. --- 0011/drivers/staging/board/Kconfig +++ work/drivers/staging/board/Kconfig 2014-05-29 22:32:39.000000000 +0900 @@ -1,5 +1,6 @@ config STAGING_BOARD boolean "Staging Board Support" + depends on OF && OF_ADDRESS help Select to enable per-board staging support code. Actually, there are not many dependencies - I believe the OF bits is about it. Cheers, / magnus _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel