Re: [PATCH 5/5] Staging: rtl8192u: r8192U_wx.c Removed commented out dead code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 28, 2014 at 09:49:21PM -0700, Chaitanya Hazarey wrote:
>  static iw_handler r8192_private_handler[] = {
> -	/* r8192_wx_set_monitor, */ /* SIOCIWFIRSTPRIV */
>  	r8192_wx_set_crcmon,   /*SIOCIWSECONDPRIV*/
> -	/* r8192_wx_set_forceassociate, */


The SIOCIWSECONDPRIV comment is out of date, you can just remove it.
r8192_wx_set_monitor used to be SIOCIWFIRSTPRIV but we deleted it so
now r8192_wx_set_crcmon is FIRST.

Btw, this is a question for linux-wireless, I'm suprised that it isn't
more common for the iw_priv_args[] and iw_handler[] arrays to get out
of sync.  Do we have a way to detect that?

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux