On Wednesday, May 28, 2014 3:22 AM, Ian Abbott wrote: > On 2014-05-27 18:31, H Hartley Sweeten wrote: >> THe comedi core ensures that the chanlist will be valid for any async operation >> other than Step 1 of the (*do_cmdtest) to get the trigger source masks. >> >> Remove the unnecessary checks. >> >> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> >> Cc: Ian Abbott <abbotti@xxxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > NAK. It only ensures chanlist_len is non-zero for the COMEDI_CMD ioctl, > not for the COMEDI_CMDTEST ioctl. So both chanlist_len checks are > necessary below. Ugh.. I thought I caught all of these when you pointed this out earlier. Greg, Can you please drop this one and take the rest of the series. Thanks, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
