Re: [PATCH] Staging: speakup: don't die if accessing sysfs without synth

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sasha Levin, le Tue 27 May 2014 19:08:36 -0400, a écrit :
> Setting a 'silent' parameter without a synth would crash the kernel.
> 
> Signed-off-by: Sasha Levin <sasha.levin@xxxxxxxxxx>

Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

> ---
>  drivers/staging/speakup/synth.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
> index 0b3549b..172cf62 100644
> --- a/drivers/staging/speakup/synth.c
> +++ b/drivers/staging/speakup/synth.c
> @@ -212,6 +212,9 @@ void synth_start(void)
>  
>  void spk_do_flush(void)
>  {
> +	if (!synth)
> +		return;
> +
>  	speakup_info.flushing = 1;
>  	synth_buffer_clear();
>  	if (synth->alive) {
> -- 
> 1.7.10.4
> 

-- 
Samuel
Now I know someone out there is going to claim, "Well then, UNIX is intuitive,
because you only need to learn 5000 commands, and then everything else follows
from that! Har har har!"
(Andy Bates in comp.os.linux.misc, on "intuitive interfaces", slightly
defending Macs.)
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel





[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux