On Mon, May 26, 2014 at 01:24:20PM +0200, Jes Sorensen wrote: > Let me ask this another way, does every patch submission have to end up > in a nit-picking session over non-issues? I get the distinct impression > you simply want to comment just to have the last word. You feel like I am singling you out for special nit-picks but honestly that isn't true. When I'm reviewing code, I am mechanical about it. I have made the same review comment to everyone who introduced a do while statement like this. Here is one from May 19. https://www.mail-archive.com/driverdev-devel@xxxxxxxxxxxxxxxxxxxxxx/msg10259.html > As I said, I took care of the non void returning functions to make sure > there were no side effects. The kernel has a presedence for allowing > this for years and unless you can show me an example of where the > construct I used can have potential side effects, I can only consider > this as unnecessary fuss. Kernel programmers are actually very paranoid about macros. There are 107 macros like this in the kernel so it's fairly rare. But obviously there are still side effect bugs in the kernel. DBG("Bogus frame ? %d\n", ++(cam->nb)); Stop being mean to me. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
