On Fri, May 23, 2014 at 10:23:43PM +0200, Matthias Beyer wrote:
> Signed-off-by: Matthias Beyer <mail@xxxxxxxxxxxxxxxx>
> ---
> drivers/staging/bcm/CmHost.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
> index 59a3eb9..181c4e9 100644
> --- a/drivers/staging/bcm/CmHost.c
> +++ b/drivers/staging/bcm/CmHost.c
> @@ -1923,13 +1923,16 @@ static void restore_endianess_of_pstClassifierEntry(
> enum bcm_ipaddr_context eIpAddrContext)
> {
> int i;
> + union u_ip_address *stSrc = &pstClassifierEntry->stSrcIpAddress;
> + union u_ip_address *stDest = &pstClassifierEntry->stDestIpAddress;
Arg!!!! These new names follow the same horrible naming standard used
in the rest of this horrible driver. The correct names were "src" and
"dst" or "dest".
Staging drivers start out as bad style, then we slowly change them to
a mix of good style and bad style and then we fix them until the bad
style is gone. Don't worry about being inconsistent if the old code is
garbage.
Anyway, this patch is an improvement from the original code so I won't
ask you to resend it.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
