Re: [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2014-05-25 at 21:58 -0700, Chaitanya Hazarey wrote:
> Added a blank line after declarations in many places to fix
> the following warning issued by checkpatch.pl:

Unrelated trivial note:

> diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c

> @@ -2802,6 +2813,7 @@ int wdt_time_left(struct bpctl_dev *pbpctl_dev)
>  static int wdt_timer(struct bpctl_dev *pbpctl_dev, int *time_left)
>  {
>  	int ret = 0;
> +
>  	if (pbpctl_dev->bp_caps & WD_CTL_CAP) {
>  		{
>  			if (pbpctl_dev->wdt_status == WDT_STATUS_UNKNOWN)

unnecessary and ugly double brace


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux