Re: [PATCH 40/74] staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h defines to set qos_ctrl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 21, 2014 at 01:59:04PM +0200, Jes Sorensen wrote:
> Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:
> > On Wed, May 21, 2014 at 09:38:04AM +0200, Jes.Sorensen@xxxxxxxxxx wrote:
> >> From: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
> >> 
> >> Signed-off-by: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
> >> ---
> >>  drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 9 +++++----
> >>  1 file changed, 5 insertions(+), 4 deletions(-)
> >> 
> >> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
> >> index dc044cf..eb747d6 100644
> >> --- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
> >> +++ b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
> >> @@ -383,13 +383,14 @@ ConstructNullFunctionData(struct rtw_adapter *padapter, u8 *pframe,
> >>  	}
> >>  
> >>  	if (bQoS == true) {
> >> -		struct ieee80211_qos_hdr *pwlanqoshdr;
> >> +		struct ieee80211_qos_hdr *qoshdr;
> >> +		qoshdr = (struct ieee80211_qos_hdr *)pframe;
> >
> > Checkpatch complains about these nowadays.
> >
> > It's obviously a minor thing.  No need to resend.  No need to respond to
> > this email at all, in fact.
> 
> Sorry you baffled me there - it complains about what here?
> 

WARNING: Missing a blank line after declarations
#32: FILE: drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:387:
+               struct ieee80211_qos_hdr *qoshdr;
+               qoshdr = (struct ieee80211_qos_hdr *)pframe;

total: 0 errors, 1 warnings, 18 lines checked

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux