On Tue, May 20, 2014 at 05:12:44PM +0200, Matthias Beyer wrote: > @@ -410,7 +412,8 @@ static int bcm_char_ioctl_gpio_set_request(void __user *argp, > if (IoBuffer.InputLength > sizeof(gpio_info)) > return -EINVAL; > > - if (copy_from_user(&gpio_info, IoBuffer.InputBuffer, IoBuffer.InputLength)) > + if (copy_from_user(&gpio_info, IoBuffer.InputBuffer, > + IoBuffer.InputLength)) Could you align this like: if (copy_from_user(&gpio_info, IoBuffer.InputBuffer, IoBuffer.InputLength)) return -EFAULT; In other words: [tab][tab][tab][space][space][space]IoBuffer.InputLength)) That way the 'I' and the '&' are in the same column. Do that same thing for all the function calls. The calls to wait_event_interruptible_timeout() might not work right if we do it this way so in that case do whatever looks nicest. But otherwise, please line them up. For the next two patches as well. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
