Re: [PATCH 2/2] staging: slicoss: remove slic_reg_params struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 19, 2014 at 12:52 PM, Dan Carpenter
<dan.carpenter@xxxxxxxxxx> wrote:
>
> You have to understand that I review a lot of staging patches every day.
> Most patches try to remove struct members but the code should still work
> exactly as it did before (a clean up).  Some patches remove struct
> members and the behavior changes.  Hopefully it's deliberate and the
> changelog mentions that it is a bug fix.  If it changes the run time,
> and not deliberately then that's a bug.
>

Ah I see. This patch does indeed change the behavior. Since I plan to resend
the other patch in this series, I'll fix the changelog for this patch as well.

Thanks for the review.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux