On Mon, May 19, 2014 at 4:22 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Sun, May 18, 2014 at 08:48:58PM +0530, navin patidar wrote:
>> Signed-off-by: navin patidar <navin.patidar@xxxxxxxxx>
>> ---
>> drivers/staging/rtl8188eu/hal/usb_halinit.c | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
>> index 1a83d31..4c3f8c8 100644
>> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
>> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
>> @@ -2231,12 +2231,6 @@ static void rtl8188eu_init_default_value(struct adapter *adapt)
>> haldata->odmpriv.RFCalibrateInfo.ThermalValue_HP[i] = 0;
>> }
>>
>> -static u8 rtl8188eu_ps_func(struct adapter *Adapter, enum hal_intf_ps_func efunc_id, u8 *val)
>> -{
>> - u8 bResult = true;
>> - return bResult;
>> -}
>> -
>> void rtl8188eu_set_hal_ops(struct adapter *adapt)
>> {
>> struct hal_ops *halfunc = &adapt->HalFunc;
>> @@ -2277,7 +2271,5 @@ void rtl8188eu_set_hal_ops(struct adapter *adapt)
>> halfunc->hal_xmit = &rtl8188eu_hal_xmit;
>> halfunc->mgnt_xmit = &rtl8188eu_mgnt_xmit;
>>
>> - halfunc->interface_ps_func = &rtl8188eu_ps_func;
>
> No, this is used. See rtw_hal_intf_ps_func().
>
> drivers/staging/rtl8188eu/hal/hal_intf.c
> 210 u8 rtw_hal_intf_ps_func(struct adapter *adapt,
> 211 enum hal_intf_ps_func efunc_id, u8 *val)
> 212 {
> 213 if (adapt->HalFunc.interface_ps_func)
> 214 return adapt->HalFunc.interface_ps_func(adapt, efunc_id,
> 215 val);
> 216 return _FAIL;
> 217 }
>
> You have changed it to return _FAIL instead of true. Perhaps that is ok
> but you need to explain it in the changelog.
>
oops, I'll resend this patch with proper changelog.
I have one question, do i need to send v2 of whole patch series or
just this patch.
regards,
navin patidar
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
