Re: [PATCH 2/5] staging: xgifb: Drop pr_fmt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 18, 2014 at 12:55:13PM +0200, Lubomir Rintel wrote:
> It is neither used nor useful.

Not true at all.

> 
> Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>
> ---
>  drivers/staging/xgifb/XGI_main_26.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index a62d4dd..d61e03f 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -4,8 +4,6 @@
>   * Base on TW's sis fbdev code.
>   */
>  
> -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> -

This affects all pr_* functions that come after this line, setting up
the prefix for the message.  So it is needed, unless you get rid of all
pr_* functions in the file, which I don't think you have...

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux