On Sat, May 17, 2014 at 12:38:57PM +0200, Christian Engelmayer wrote: > Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS > as long as not explicitly set. Thus initialize 'status' to FAIL, in order to > prevent undefined behaviour if going through the exit paths. Detected by > Coverity - CID 1077832. > > Signed-off-by: Christian Engelmayer <cengelma@xxxxxx> This is a bugfix and we like to merge bugfixes without asking redo things, so don't redo. But really the better fix is to get rid of the status variable completely. Just return directly on the success path. If we were to do that, then both patches would be merged together and called: [patch] Staging: rtl8188eu: fix error handling in rtw_drv_init() But this patch is also acceptable as-is. Thanks for fixing the bug. :) regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
