Re: [PATCH] staging: wlan-ng: use pr_err() instead of KERN_ERR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 13, 2014 at 09:22:16PM +1000, Vitaly Osipov wrote:
> All files in drivers/staging/wlan-ng updated to use pr_err
> 
> Signed-off-by: Vitaly Osipov <vitaly.osipov@xxxxxxxxx>
> ---
>  drivers/staging/wlan-ng/p80211conv.c   |   24 +++++------
>  drivers/staging/wlan-ng/p80211netdev.c |    7 ++-
>  drivers/staging/wlan-ng/p80211req.c    |    3 +-
>  drivers/staging/wlan-ng/prism2fw.c     |   65 +++++++++++-----------------
>  drivers/staging/wlan-ng/prism2mgmt.c   |   74 +++++++++++++-------------------
>  drivers/staging/wlan-ng/prism2mib.c    |    2 +-
>  6 files changed, 70 insertions(+), 105 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c
> index 3df753b..7e6c7b6 100644
> --- a/drivers/staging/wlan-ng/p80211conv.c
> +++ b/drivers/staging/wlan-ng/p80211conv.c
> @@ -195,8 +195,7 @@ int skb_ether_to_p80211(wlandevice_t *wlandev, u32 ethconv,
>  		memcpy(p80211_hdr->a3.a3, &e_hdr.saddr, ETH_ALEN);
>  		break;
>  	default:
> -		printk(KERN_ERR
> -		       "Error: Converting eth to wlan in unknown mode.\n");
> +		pr_err("Error: Converting eth to wlan in unknown mode.\n");

This is a network driver, why can't it use netdev_err()?  Or at the
least dev_err()?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux