On Wed, May 14, 2014 at 09:28:27PM +0200, Pawel Lebioda wrote: > Fix bad function definitions in all files from drivers/staging/usbip directory > > Signed-off-by: Pawel Lebioda <pawel.lebioda89@xxxxxxxxx> This is fine, but next time try to be more specific in the subject and also in the changelog. Put the sparse warning in the changelog. Say that you are adding "void". Btw, the reason for the void is because if it's not void then the compiler won't complain if you pass a parameter to it. void frob() { printf("foo\n"); } int main(void) { frob(1, 2, 3); return 0; } regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel